Remove the use of AnalysisDriver.addFile #1825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Nov 9, 2018
scheglov
approved these changes
Nov 9, 2018
|
The build is failing because: but I have no idea what that means. Any help tracking this down and fixing it would be welcome. |
|
This PR is likely fine; the problem there was introduced by some of the tooling support changes Greg is working on. I'm going to disable one of the tests until that gets fixed in #1824. |
|
Great! Is there any way to force it to try again? |
|
Yes; I'll do that once I have a complete solution to the nasty bugs causing the assert failures. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@scheglov assures me that this isn't necessary, and that this is likely what's causing the analysis session to be invalidated. The larger set of changes isn't currently working, but this passes all the tests, so I thought it was worth getting it committed separately.