Library loading refactor, drop analysis error checking #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Nov 20, 2018
|
PTAL. I've changed how we're getting LibraryElements to a method that is not as horribly slow, and also eliminated some other inefficiencies to gain back some performance lost with this change. |
bwilkerson
approved these changes
Nov 21, 2018
lib/src/model.dart
Outdated
| @@ -6640,14 +6605,16 @@ class PackageBuilder { | |||
| } | |||
| } | |||
|
|
|||
| int counter = 0; | |||
| int counter2 = 0; | |||
There was a problem hiding this comment.
I don't see any reference to these fields. Are they needed?
If so, consider renaming them to indicate what they're counting.
There was a problem hiding this comment.
whoops, these are debugging leftovers. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis error checking is too difficult to do at this stage, so just drop it. It was inaccurate before.
Cleans up how we calculate libraries to be sure we get the transitive set of libraryElements when landing, and eliminate duplicitous excludes checking.