Remove computeNode and use new analyzer interfaces for library retrieval #1851
Conversation
|
Should be ready for review now with the publish of analyzer 0.33.5. |
…iles in time for empty packages
|
Fixed a race condition in library detection found by the integration tests, but waiting for Flutter tests to pass on a republish of analyzer's dependencies that include dev-9.4 in their SDK ranges. |
| Future<List<LibraryElement>> _parseLibraries(Set<String> files) async { | ||
| Iterable<LibraryElement> libraries = new Iterable.empty(); | ||
| Future<Map<LibraryElement, ResolvedLibraryResult>> _parseLibraries(Set<String> files) async { | ||
| Map<LibraryElement, ResolvedLibraryResult> libraries = new Map(); |
There was a problem hiding this comment.
Consider replacing "new Map()" with "{}".
jcollins-g
changed the title
|
Another integration test failure for angular seems to be due to increased memory usage (since we're hanging on to many astNodes now this is not too surprising). I'll see if there's something simple I can find in the profiler to make things better while waiting for the next publish. |
|
As expected, new analyzer publish fixes the version issue. But flutter is also blocked on the peak heap size problem. I have some threads to pursue on this. |
Refactors PackageGraph and Library construction to preserve the ResolvedLibraryResult objects from the analyzer, which contain the necessary AST nodes for Dartdoc ModelElements to be able to resolve source code and comment references. This PR is the culmination of a joint effort with @bwilkerson, @scheglov and others, many thanks for all their efforts.