Breakdown comment reference handling further and tweak performance #1863
Conversation
| @@ -6568,8 +6603,6 @@ class PackageBuilder { | |||
| PerformanceLog log = new PerformanceLog(null); | |||
| AnalysisDriverScheduler scheduler = new AnalysisDriverScheduler(log); | |||
| AnalysisOptionsImpl options = new AnalysisOptionsImpl(); | |||
| options.enableSuperMixins = true; | |||
| options.previewDart2 = true; | |||
|
|
|||
| // because of accessors and operators. | ||
| if (_namePart == null) { | ||
| _namePart = fullyQualifiedName.split('.').last; | ||
| } |
There was a problem hiding this comment.
Silly, and kind of an aside but I'm curious nonetheless about shorthand (since I do this kind of lazy init all the time).
How crazy is something like this?
return _namePart ??= fullyQualifiedName.split('.').last;
There was a problem hiding this comment.
I'll use that but I now do it only sparingly for really trivial things (e.g. ??= super.foo). The reason is threefold; one, ??= is kind of obscure and even after programming in Dart for a couple years I still pause for a second when I see it.
Two, if I need to add debugging code for any reason, or want to add something more complex to the statement, I have to add all the boilerplate then rather than concentrate on what I was doing, and then remember to remove it.
And finally, since there are plenty of cases where ??= isn't appropriate stylistically anyway (if we're doing more than one or two lines of work), I prefer to have this idiom look the same wherever I see it. This way I can concentrate on important things and let this fade into the background by making use of my human brain's ability to process repetitive sequences subconsciously. Dartdoc isn't quite consistent but I'd like it to be eventually.
Minor improvement to comment reference handling; this now makes comment reference handling overall negligible for performance (~ 5 seconds spent on a flutter run now) and hopefully reduces further the amount of cut-and-pastyness going on in the reference handling. It should make it easier when we go in to rewrite that to understand what the current code does.
In addition, disable by default the high quality stack traces inside the
Chain.capture()call. This has a more significant performance impact.