Skip to content

Enhance coverage to cover all appropriate binary-level tests #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 2, 2019

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Dec 21, 2018

Expand our use of the coverage subprocess launcher to cover launches of dartdoc from tests, when appropriate. Skips the actual comparing of output test as it's too high level to be of much use when checking code coverage.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 21, 2018
@jcollins-g jcollins-g changed the title WIP: Enhance coverage to cover all appropriate binary-level tests Enhance coverage to cover all appropriate binary-level tests Dec 21, 2018
@coveralls
Copy link

coveralls commented Dec 22, 2018

Coverage Status

Coverage increased (+1.06%) to 92.642% when pulling 5956cf6 on cleanup-more-unused+coverage-enhancement into 04ed8ec on master.

@jcollins-g jcollins-g requested a review from devoncarew January 2, 2019 18:16
@jcollins-g jcollins-g merged commit a86cd9b into master Jan 2, 2019
@jcollins-g jcollins-g deleted the cleanup-more-unused+coverage-enhancement branch January 2, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants