Skip to content

Merge from main branch to NNBD #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 11, 2021

Conversation

jcollins-g
Copy link
Contributor

Includes changes for lints as well as the constructor refactoring to support NNBD.

jcollins-g and others added 11 commits September 30, 2021 11:05
…ent (dart-lang#2817)

* Straight move

* Partial

* delete experiment

* rebuild

* remove ??= from a cut and paste
* Straight move

* Partial

* delete experiment

* rebuild

* moved computeDocumentationComment and documentationComment

* Move more documentation comment handling

* remove ??= from a cut and paste

* Documentation comment move for combos

* better as a getter
…#2821)

* Remove all deprecated bits in preparation for next release

* make some things final
* Straight move

* Partial

* delete experiment

* rebuild

* moved computeDocumentationComment and documentationComment

* Move more documentation comment handling

* remove ??= from a cut and paste

* Documentation comment move for combos

* better as a getter

* Untangle synthetic combo documentation in preparing for non-null

* rebuild

* documentationComment can be made non-nullable

* Update test.yaml to delete sdk check from beta branch

* tab conversion error

* correct name
* disable beta

* try switching on stable

* stable doesn't work for a lot of things now either :-(

* try enabling the main bot
* partial

* analyzes

* finish refactor

* rebuild and delete an unnecessary reference

* rebuild

* dartfmt

* Rename to ModelObjectBuilder so that we can build more than just ModelElements

* complete rename
…rtdoc (dart-lang#2830)

* switch to lints/core.yaml

* recommended

* presubmit cleanup

* oops, recommended on presubmit too
@jcollins-g jcollins-g added the nnbd label Oct 8, 2021
@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Oct 8, 2021
@jcollins-g jcollins-g requested a review from srawlins October 8, 2021 20:57
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ones a doozy!

@jcollins-g jcollins-g merged commit 8d827d1 into dart-lang:nnbd Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants