Migrate debugger instance helper to null safety #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
June 23, 2022 10:43
…ll-safety-dwds-domain
…ll-safety-dwds-debugging3
elliette
reviewed
Jul 11, 2022
| properties.sublist(0, min(count ?? length, numberOfProperties)); | ||
| : (await instanceRefFor(remoteObject))?.length; | ||
| final indexed = properties.sublist( | ||
| 0, min(count ?? length ?? numberOfProperties, numberOfProperties)); |
There was a problem hiding this comment.
I know this whole block of code from line 278 - 283 was already here before the null-safety migration, but trying to follow everything going on is pretty confusing. Maybe we could pull this out into a couple helper methods (e.g., _getPropertiesSublist if offset and count are set, and _getAllProperties if not)? Also are we using offset anywhere? I would think it should be the first argument to .sublist if it's defined.
There was a problem hiding this comment.
Would it be ok to do it in a separate PR? This way we could figure out what the offset is for and add some tests as well, without mixing too many changes in the null-safety migration PR.
elliette
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate debugger/instance.dart helper to null safety
Towards: #1327