[MV3] Dart Debug Extension supports cross-extension communication with AngularDart DevTools #1866
Conversation
| @@ -17,14 +17,17 @@ import 'logger.dart'; | |||
|
|
|||
| enum StorageObject { | |||
| debugInfo, | |||
| devToolsOpener; | |||
| devToolsOpener, | |||
| encodedUri; | |||
|
|
|||
| String get keyName { | |||
There was a problem hiding this comment.
Enum values now have a property called name which matches this implementation.
There was a problem hiding this comment.
Oh nice! Using that instead
| @@ -194,14 +198,12 @@ void _routeDwdsEvent(String eventData, SocketClient client, int tabId) { | |||
| final message = serializers.deserialize(jsonDecode(eventData)); | |||
| if (message is ExtensionRequest) { | |||
| _forwardDwdsEventToChromeDebugger(message, client, tabId); | |||
| } else if (message is ExtensionEvent) { | |||
There was a problem hiding this comment.
ExtensionRequest and ExtensionEvent are mutually exclusive, any reason to remove the else?
There was a problem hiding this comment.
No reason, added back in the else if
| @@ -6,6 +6,11 @@ | |||
| "action": { | |||
| "default_icon": "static_assets/dart_dev.png" | |||
| }, | |||
| "externally_connectable": { | |||
| "ids": [ | |||
| "nbkbficgbembimioedhceniahniffgpl" | |||
There was a problem hiding this comment.
Maybe a comment here indicating this is the ACX extension.
There was a problem hiding this comment.
No comments allowed in JSON unfortunately
| chrome.runtime.onMessage.addListener( | ||
| allowInterop(_handleRuntimeMessages), | ||
| ); | ||
| chrome.runtime.onMessageExternal.addListener( |
There was a problem hiding this comment.
Maybe a comment indicating that we only allow the ACX extension to communicate with this extension due to the manifest config.
There was a problem hiding this comment.
Done, added one here and in cross_extension_communication
No description provided.