Skip to content

[dwds] Cleanup unused null safety related fields #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
## 24.4.2-wip
## 25.0.0-wip

- Implemented hot restart over websockets with multi window support.
- Fix refresh race condition bug by adding an isolate destruction grace period.
- Update a call to the `package:shelf_web_socket` `webSocketHandler()` function.
- Remove deprecated parameter `injectDebuggingSupportCode` from `Dwds.start()`.
- Remove all deprecated fields, getters, and parameters
related to the null safety compilation mode. Dart 3 only
supports [sound null safety](https://dart.dev/null-safety).

## 24.4.1

Expand Down
5 changes: 0 additions & 5 deletions dwds/lib/dart_web_debug_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@ class Dwds {
required Stream<BuildResult> buildResults,
required ConnectionProvider chromeConnection,
required ToolConfiguration toolConfiguration,
// ignore: avoid-unused-parameters
@Deprecated(
'This parameter is ignored and will be removed in a future version.',
)
bool injectDebuggingSupportCode = true,
bool useDwdsWebSocketConnection = false,
}) async {
globalToolConfiguration = toolConfiguration;
Expand Down
22 changes: 9 additions & 13 deletions dwds/lib/data/build_result.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 6 additions & 21 deletions dwds/lib/data/connect_request.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

50 changes: 14 additions & 36 deletions dwds/lib/data/debug_event.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 5 additions & 7 deletions dwds/lib/data/debug_info.g.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading