Skip to content

Update datetime_is_numeric behavior in describe for pandas 2.0 #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

j-bennet
Copy link
Contributor

Xref: #9736
Xref: pandas-dev/pandas#49368

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j-bennet! Apologies for the delayed reply here. The dask/dataframe/tests/test_dataframe.py::test_describe_without_datetime_is_numeric mindeps failure looks legitimate.

@j-bennet j-bennet changed the title Fix describe, pandas 2.0 compatibility Fix describe for pandas 2.0 compatibility Feb 6, 2023
@j-bennet
Copy link
Contributor Author

j-bennet commented Feb 6, 2023

dask/dataframe/tests/test_dataframe.py::test_describe_without_datetime_is_numeric mindeps failure looks legitimate.

@jrbourbeau This is now fixed.

@jrbourbeau jrbourbeau changed the title Fix describe for pandas 2.0 compatibility Update datetime_is_numeric behavior in describe for pandas 2.0 Feb 9, 2023
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j-bennet! Will merge once CI finishes

@jrbourbeau jrbourbeau merged commit dcd008f into dask:main Feb 9, 2023
@j-bennet j-bennet deleted the j-bennet/9736-upstream-fix-describe branch February 10, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants