-
Notifications
You must be signed in to change notification settings - Fork 88
Feat/plugins - deprecate otumate and old plugins #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes deprecated plugin functionality from DataJoint, specifically deprecating the otumate library and associated plugin verification system. The changes simplify the codebase by removing cryptographic verification of plugins and the plugin loading mechanism.
Key changes:
- Removes the entire plugin verification system including cryptographic signature checking
- Eliminates dependencies on otumate and cryptography libraries
- Removes plugin-based connection handling and custom attribute adapters
- Adds comprehensive documentation for the three-part make pattern for long computations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
tests/test_plugin.py | Completely removes all plugin-related tests |
pyproject.toml | Removes otumate and cryptography dependencies |
docs/src/compute/populate.md | Adds extensive documentation for three-part make pattern |
datajoint/plugin.py | Removes entire plugin module with verification logic |
datajoint/errors.py | Simplifies DataJointError by removing plugin warning mechanism |
datajoint/connection.py | Removes plugin-based connection hooks and simplifies connection logic |
datajoint/attribute_adapter.py | Removes plugin-based attribute adapter loading |
.devcontainer/devcontainer.json | Adds SSH agent mounting for development environment |
Co-authored-by: Copilot <[email protected]>
Fixing #1252 and initial part of #1251