Skip to content

Feat/plugins - deprecate otumate and old plugins #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 12, 2025
Merged

Conversation

dimitri-yatsenko
Copy link
Member

Fixing #1252 and initial part of #1251

@dimitri-yatsenko dimitri-yatsenko requested a review from Copilot July 29, 2025 00:49
@github-actions github-actions bot added enhancement Indicates new improvements documentation Issues related to documentation feature Indicates new features labels Jul 29, 2025
Copilot

This comment was marked as outdated.

Co-authored-by: Copilot <[email protected]>
@dimitri-yatsenko dimitri-yatsenko requested a review from Copilot July 29, 2025 00:55
Copilot

This comment was marked as outdated.

@dimitri-yatsenko dimitri-yatsenko marked this pull request as draft July 29, 2025 01:20
@dimitri-yatsenko dimitri-yatsenko marked this pull request as ready for review July 29, 2025 01:20
@dimitri-yatsenko dimitri-yatsenko requested a review from Copilot July 29, 2025 02:59
Copilot

This comment was marked as outdated.

@dimitri-yatsenko dimitri-yatsenko requested a review from Copilot July 29, 2025 03:04
Copilot

This comment was marked as outdated.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated plugin functionality from DataJoint, specifically deprecating the otumate library and associated plugin verification system. The changes simplify the codebase by removing cryptographic verification of plugins and the plugin loading mechanism.

Key changes:

  • Removes the entire plugin verification system including cryptographic signature checking
  • Eliminates dependencies on otumate and cryptography libraries
  • Removes plugin-based connection handling and custom attribute adapters
  • Adds comprehensive documentation for the three-part make pattern for long computations

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_plugin.py Completely removes all plugin-related tests
pyproject.toml Removes otumate and cryptography dependencies
docs/src/compute/populate.md Adds extensive documentation for three-part make pattern
datajoint/plugin.py Removes entire plugin module with verification logic
datajoint/errors.py Simplifies DataJointError by removing plugin warning mechanism
datajoint/connection.py Removes plugin-based connection hooks and simplifies connection logic
datajoint/attribute_adapter.py Removes plugin-based attribute adapter loading
.devcontainer/devcontainer.json Adds SSH agent mounting for development environment

Co-authored-by: Copilot <[email protected]>
@ttngu207 ttngu207 merged commit 35dbbfa into master Aug 12, 2025
4 checks passed
@ttngu207 ttngu207 deleted the feat/plugins branch August 12, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues related to documentation enhancement Indicates new improvements feature Indicates new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants