Skip to content

Enable multiple artifact download & artifact name via regex #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

joseph-flinn
Copy link

Summary

First off, I have found this Action very useful! Thanks for creating it!

For workflows that need multiple artifacts from another workflow, but not all, I'd like the ability to specify specifically which ones to get to avoid downloading more than I need. This change enables that.

@dawidd6 dawidd6 self-assigned this Sep 23, 2021
@dawidd6
Copy link
Owner

dawidd6 commented Sep 23, 2021

Why not just running the Action a few more times to get each artifact separately?

@joseph-flinn
Copy link
Author

One of the workflows that I'm working in requires 6 artifacts. This is a lot of copy/paste which is anti-DRY. Since this Action has the ability to download a single artifact as well as all of the artifacts, I didn't think that adding a filter for some artifacts would change the philosophy of this project.

@dawidd6
Copy link
Owner

dawidd6 commented Sep 23, 2021

Okay, could you modify your changes to also resolve this issue?:
#85

Supporting regex as name would also enable multiple names matching as you want.

@joseph-flinn
Copy link
Author

Sure. The regex functionality has been added.

@joseph-flinn joseph-flinn changed the title Enabling multiple specific artifact download Enabling multiple artifact download & artifact name via regex Sep 24, 2021
@joseph-flinn joseph-flinn changed the title Enabling multiple artifact download & artifact name via regex Enable multiple artifact download & artifact name via regex Jan 11, 2022
@bboles
Copy link

bboles commented Aug 5, 2022

Hi @dawidd6, is there something else holding up this PR from being merged?

@joseph-flinn
Copy link
Author

I tried resolving the conflicts that have popped up over the last year, but have lost the context to working on this action and don't quite have the capacity to spin back up it.

There's a "fork" over here that adds this functionality. That being said, it is provided as-is as there isn't enough capacity on my team to support additional features than what my team needs.

@dawidd6 dawidd6 removed their assignment Aug 30, 2022
@dawidd6
Copy link
Owner

dawidd6 commented Aug 30, 2022

Closing for now, because of the conflicts. If someone wants to take over the work and push it forward, please open a new PR.

@dawidd6 dawidd6 closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants