-
Notifications
You must be signed in to change notification settings - Fork 66
Remove unused chectl flag #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: David Kwon <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: David Kwon <[email protected]>
Signed-off-by: David Kwon <[email protected]>
/retest |
It's quite strange, even after defining a long timeout it's failing
|
.ci/oci-devworkspace-happy-path.sh
Outdated
@@ -42,8 +42,8 @@ deployChe() { | |||
-p openshift \ | |||
--batch \ | |||
--telemetry=off \ | |||
--installer=operator \ | |||
--workspace-engine=dev-workspace | |||
--k8spodreadytimeout=240000 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that in che-operator we're using slightly longer timeout --k8spodreadytimeout=6000000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I will update the PR
Signed-off-by: David Kwon <[email protected]>
Signed-off-by: David Kwon <[email protected]>
I realized it's timing out because chectl is waiting for the DWO operands to be ready in the The DWO operands in
since the operands in My commit: b6c668e should fix the problem |
Signed-off-by: David Kwon <[email protected]>
There is a new error:
|
/retest |
Signed-off-by: David Kwon <[email protected]>
/retest |
1 similar comment
/retest |
With these changes, I can see that
Do you have any idea about this? |
I think I figured out the issue, I will create a new issue |
/retest |
Merging, happy path tests now passed! |
What does this PR do?
Removes the
--workspace-engine=dev-workspace
flag in the ci jobWhat issues does this PR fix or reference?
Should fix this error in the ci check:
Example failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/devfile_devworkspace-operator/1461/pull-ci-devfile-devworkspace-operator-main-v14-che-happy-path/1949933534399434752
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che