-
Notifications
You must be signed in to change notification settings - Fork 3
chore: add snap-in version upgrade compatibility doc #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,136 @@ | ||||||
This section outlines the compatibility rules when upgrading snap-in versions. These rules determine what changes are allowed in a patch upgrade. | ||||||
|
||||||
## Connections | ||||||
- New optional connections can be added. | ||||||
- New required connections cannot be added. | ||||||
- Existing connections can be removed. | ||||||
- For existing connections: | ||||||
- Description can be changed. | ||||||
- Display name can be changed. | ||||||
- New keyring types can be added. | ||||||
- Existing keyring types cannot be removed. | ||||||
- Optional connections cannot be made required. | ||||||
- Required connections can be made optional. | ||||||
|
||||||
## Event Sources | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- New event sources cannot be added. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can add new event sources |
||||||
- Existing event sources cannot be removed. | ||||||
- For existing event sources: | ||||||
- Description can be changed. | ||||||
- Display name can be changed. | ||||||
- Type cannot be changed. | ||||||
- Connection can be removed but cannot be changed. | ||||||
- Source config can be changed (test changes thoroughly). | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- Setup instructions can be changed. | ||||||
- Function can be changed. | ||||||
|
||||||
## Tags | ||||||
- New tags can be added. | ||||||
- Existing tags cannot be removed. | ||||||
- For existing tags: | ||||||
- Description can be changed. | ||||||
|
||||||
## Automations | ||||||
- Full flexibility - can be added, removed, or modified. | ||||||
- Description can be changed. | ||||||
- Source can be changed. | ||||||
- Allowed event types can be changed. | ||||||
- Function to execute can be changed. | ||||||
|
||||||
## Hooks | ||||||
- New hook types can be added. | ||||||
- Existing hook types can be removed. | ||||||
- Function to execute can be changed. | ||||||
|
||||||
## Functions | ||||||
- Full flexibility - can be added, removed, or modified. | ||||||
- All properties can be changed. | ||||||
|
||||||
## Commands | ||||||
- Full flexibility - can be added, removed, or modified. | ||||||
- All properties can be changed. | ||||||
|
||||||
## Snap Kit Actions | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- Can be removed | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [EkLine] reported by reviewdog 🐶
Suggested change
|
||||||
- For existing snap kit actions: | ||||||
- Description can be changed. | ||||||
- Function can be changed. | ||||||
|
||||||
## Snap Components | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- Can be removed | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [EkLine] reported by reviewdog 🐶
Suggested change
|
||||||
- For existing snap components: | ||||||
- Display name can be changed. | ||||||
- Description can be changed. | ||||||
- Surface cannot be changed. | ||||||
- Snap kit action name can be changed. | ||||||
- Snap kit body can be changed. | ||||||
- Initializer can be changed. | ||||||
|
||||||
## Service Account | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- Display name can be changed. | ||||||
- Description can be changed. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We cannot set description from the manifest |
||||||
|
||||||
## Inputs (Global Variables) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- Can be added or removed. | ||||||
- For existing inputs: | ||||||
- Type cannot be changed. | ||||||
- All other properties can be modified. | ||||||
|
||||||
## Imports | ||||||
- New imports can be added. | ||||||
- Existing imports cannot be removed. | ||||||
- For existing imports: | ||||||
- Display name can be changed. | ||||||
- Description can be changed. | ||||||
- Function cannot be changed. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. function can be changed |
||||||
- New allowed keyring types can be added. | ||||||
- Existing allowed keyring types cannot be removed. | ||||||
- Function name can be changed. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks repeated |
||||||
- Loader function cannot be removed once set. | ||||||
|
||||||
## User Level Keyrings | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- New keyrings can be added. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't allow required user level keyrings |
||||||
- Existing keyrings can be removed. | ||||||
- For existing keyrings: | ||||||
- Description can be changed. | ||||||
- Display name can be changed. | ||||||
- New allowed types can be added. | ||||||
- Existing allowed types cannot be removed. | ||||||
- Required keyrings can be made optional. | ||||||
|
||||||
## User Level Inputs | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- Can be added or removed. | ||||||
- For existing inputs: | ||||||
- Type cannot be changed. | ||||||
- All other properties can be modified. | ||||||
|
||||||
## Keyring Types | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- Can be added or removed. | ||||||
- For existing keyring types: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @SathishKumarHS Please check There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||
- Name can be changed. | ||||||
- Description can be changed. | ||||||
- Scopes can be changed. | ||||||
- Scope delimiter can be changed. | ||||||
- Authorize, refresh, and revoke functions can be changed. | ||||||
- Organization data can be changed. | ||||||
- External service name can be changed. | ||||||
- Kind cannot be changed. | ||||||
- Keyring type template cannot be changed. | ||||||
- OAuth secret ID cannot be changed. | ||||||
|
||||||
## Functions Build Config | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove this section. Build config is not documented |
||||||
- Full flexibility - can be added, removed, or modified. | ||||||
- All properties can be changed. | ||||||
|
||||||
## Configuration Handler | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
- Full flexibility - can be added, removed, or modified. | ||||||
- All properties can be changed. | ||||||
|
||||||
## Operations | ||||||
- New operations can be added. | ||||||
- Existing operations cannot be removed. | ||||||
- For existing operations: | ||||||
- Operation type cannot be changed. | ||||||
- Input ports cannot be changed (including type and schema). | ||||||
- Output ports cannot be changed (including type and schema). | ||||||
- Keyring types follow the same rules as Connections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename it to
allowed_connection_types
or what is present in the manifest.Keyring Types
have a different meaning