Linking: fix up all types before handling functions or objects

[tautschnig]

Function parameters may require application of type fixes: our linking ensures that all types have a unique tag, and some parameter's types may require such tag updates. We used to do this for objects already, but need to apply it to parameters as well. Also, the order matters: all types need to be sorted out first before attempting objects or functions.

Spotted while trying to compile a particular version of Xen 4.11.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.40%. Comparing base (22d25d1) to head (4b55839).

Files with missing lines	Patch %	Lines
src/linking/linking.cpp	94.44%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #7579   +/-   ##
========================================
  Coverage    80.39%   80.40%           
========================================
  Files         1688     1688           
  Lines       207403   207415   +12     
  Branches        73       73           
========================================
+ Hits        166752   166777   +25     
+ Misses       40651    40638   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[harmim]

It seems this fixed my problem with building Xen 4.11. Thanks @tautschnig.