Skip to content

Fix __float128 portability #7843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Conversation

tautschnig
Copy link
Collaborator

GCC does not provide this type on all architectures.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

GCC does not provide this type on all architectures.
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: +0.45% 🎉

Comparison is base (f40203a) 78.05% compared to head (afb6b2e) 78.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7843      +/-   ##
===========================================
+ Coverage    78.05%   78.50%   +0.45%     
===========================================
  Files         1698     1698              
  Lines       195117   195119       +2     
===========================================
+ Hits        152289   153176     +887     
+ Misses       42828    41943     -885     
Files Changed Coverage Δ
src/cpp/cpp_internal_additions.cpp 86.04% <20.00%> (-2.05%) ⬇️

... and 56 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there may be some more combinations of architecture and types we're not testing in regression tests, but approving on the basis of incremental improvement is better than waiting for perfect test coverage.

@kroening kroening merged commit a373657 into diffblue:develop Aug 12, 2023
@tautschnig tautschnig deleted the bugfixes/__float128 branch August 14, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants