Context overflow. #381
Merged
Context overflow. #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidlehn
commented
Mar 13, 2020
davidlehn
commented
- Add support for context overflow tests: Context overflow. w3c/json-ld-api#416
- Attempt to support older 1.0 error code. Is this needed? (It required passing some activeCtx around to get to processing mode)
- Note: The MAX value only detects depth of recursion, not total number of remote contexts. This may be inline with the former "recursion" error code, but seems the "context overflow" should now check total remote contexts loaded (which would also handle depth). Unsure how to change the code to track that.
gkellogg
approved these changes
Mar 27, 2020
Merged
|
@davidlehn it would be nice to merge this, as other branches will fail until rebased on this work. (of course, it would be nice to get some of those merged too). |
dlongley
approved these changes
Apr 6, 2020
- Support 1.0 recursion error code. - Support 1.1 "context overflow" error code. - Allow recursion in scoped contexts.
(cherry picked from commit 020e51b57236f5496bceea6d3429a265fb4c836f)
FIXME: hard-codes version number. (cherry picked from commit 811f16c6ddd1e618de9306bd100e9c88634b82da)
davidlehn
force-pushed
the
context-overflow
branch
from
cbd6968 to
4dbecc8
Compare
Don't set `@base` in initial context and don't resolve a relative IRI when setting `@base` in a context, so that the document location can be kept separate from the context itself. This makes the initial context the same for all processingModes, allowing much more cachability of remote and resolved contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.