Skip to content

Hotfix 'Attribute error in generate code_challenge ex.' #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

islam-kamel
Copy link
Contributor

@islam-kamel islam-kamel commented Sep 20, 2022

Fixes #

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1205 (b78d09a) into master (fc0906d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1205   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          31       31           
  Lines        1813     1813           
=======================================
  Hits         1756     1756           
  Misses         57       57           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

n2ygk
n2ygk previously requested changes Sep 21, 2022
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is more of !1204?

Please add your name to AUTHORS

@islam-kamel
Copy link
Contributor Author

well done

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@n2ygk n2ygk merged commit 9383e08 into django-oauth:master Sep 22, 2022
@islam-kamel islam-kamel deleted the Hotfix branch September 22, 2022 14:04
@n2ygk n2ygk added this to the 2.2.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants