Skip to content

Bullseye and Alpine 3.15 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Nov 25, 2021

No description provided.

update.sh Outdated
echo >&2 "error: failed to determine latest release for '$version'"
exit 1
echo >&2 "warning: failed to determine latest release for '$version'"
continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems a little out of place here -- can you elaborate on it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes. The script aborts with error: missing musl build for 1.0.5 (1.0)! and 1.6/1.7-rc are not updated anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce: 😬 😕

$ ./update.sh
warning: cannot find sha256 for 1.0.5 on arch ppc64le / ppc64le (ppc64el); skipping
1.0: 1.0.5
warning: cannot find sha256 for 1.6.4 on arch ppc64le / ppc64le (ppc64el); skipping
1.6: 1.6.4
warning: cannot find sha256 for 1.7.0-rc3 on arch ppc64le / ppc64le (ppc64el); skipping
1.7-rc: 1.7.0-rc3

(All three versions are still listed on https://julialang.org/downloads/, so I don't think they're actually EOL yet, but if they are, we should remove them completely instead.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce it in a Debian container (with bash -x and curl installed):

error output
+ '[' alpine = debian ']'
+ variantArchCase='dpkgArch="$(dpkg --print-architecture)"; \
	case "${dpkgArch##*-}" in \
# amd64
		amd64) tarArch='\''x86_64'\''; dirArch='\''x64'\''; sha256='\''9dedd613777ba6ebd8aee5796915ff50aa6188ea03ed143cb687fc2aefd76b03'\'' ;; \
# arm32v7
		armhf) tarArch='\''armv7l'\''; dirArch='\''armv7l'\''; sha256='\''cfb2712765db90f0e4fa27e57a88c6d994ebcf1781f8673ebb17b5df7962d0c5'\'' ;; \
# arm64v8
		arm64) tarArch='\''aarch64'\''; dirArch='\''aarch64'\''; sha256='\''41cea1336ed8861413bb945740e567360e26f241eb3e10b3bb0fccd25655ed28'\'' ;; \
# i386
		i386) tarArch='\''i686'\''; dirArch='\''x86'\''; sha256='\''67c8f31699b79df96ce95926a363cd24ffa5bb4d9a814e071b1e8c8ff33e5a8f'\'' ;; \
		*) echo >&2 "error: current architecture ($dpkgArch) does not have a corresponding Julia binary release"; exit 1 ;; \
	esac'
+ '[' alpine = alpine ']'
++ grep 'julia-1.0.5-musl-x86_64.tar.gz$'
++ cut '-d ' -f1
++ :
+ sha256=
+ '[' -z '' ']'
+ echo 'error: missing musl build for 1.0.5 (1.0)!'
error: missing musl build for 1.0.5 (1.0)!
+ exit 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, looks like the musl builds of 1.0 are gone -- however, we should fix that by deleting the "alpine" directories in the 1.0 directory (and let the script continue to hard fail for missing things).

Copy link

@fredrikekre fredrikekre Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There never were musl builds for 1.0, Julia 1.5 was the first release with official musl binaries: https://julialang-s3.julialang.org/bin/versions.json

@J0WI J0WI force-pushed the bullseye-alpine-3.15 branch from 6ce8a11 to 60d6e4f Compare November 30, 2021 09:52
@tianon
Copy link
Member

tianon commented Nov 30, 2021

CI failures are unrelated (something to do with GitHub Actions and Windows 2016 😬).

Thanks @J0WI!

@fredrikekre thanks for the reminder about versions.json 😅 it's been on my TODO list to stop scraping the HTML and start using that fabulous resource instead, and I hope to have a PR open soon 😄

@tianon tianon merged commit 815a93c into docker-library:master Nov 30, 2021
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 30, 2021
Changes:

- docker-library/julia@815a93c: Merge pull request docker-library/julia#61 from J0WI/bullseye-alpine-3.15
- docker-library/julia@60d6e4f: Bullseye and Alpine 3.15
@J0WI J0WI deleted the bullseye-alpine-3.15 branch November 30, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants