Skip to content

[5.1] Fix | Dotnet build command #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

[5.1] Fix | Dotnet build command #2728

merged 2 commits into from
Apr 2, 2025

Conversation

dauinsight
Copy link
Contributor

No description provided.

@dauinsight dauinsight marked this pull request as draft July 26, 2024 23:06
@dauinsight dauinsight changed the title Test genapi csproj [5.1] Fix | Fix dotnet build command Jul 27, 2024
@dauinsight dauinsight changed the title [5.1] Fix | Fix dotnet build command [5.1] Fix | Dotnet build command Jul 27, 2024
@dauinsight
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cheenamalhotra cheenamalhotra added this to the 5.1.7 milestone Jan 17, 2025
@cheenamalhotra cheenamalhotra marked this pull request as ready for review January 17, 2025 18:42
@paulmedynski paulmedynski self-assigned this Mar 21, 2025
@paulmedynski paulmedynski requested review from a team and Copilot March 25, 2025 20:11
Copilot
Copilot AI reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • build.proj: Language not supported

benrr101
benrr101 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ For pete's sake... We let this sit for the better part of a year and it was a 1 character change? I'm more surprised why this wasn't a showstopper bug...

@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulmedynski paulmedynski merged commit d72e731 into dotnet:release/5.1 Apr 2, 2025
57 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@benrr101 benrr101 benrr101 approved these changes

@mdaigle mdaigle mdaigle approved these changes

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@paulmedynski paulmedynski paulmedynski approved these changes

Assignees

@paulmedynski paulmedynski

Labels
None yet
Projects
None yet
Milestone
5.1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@dauinsight @paulmedynski @benrr101 @mdaigle @cheenamalhotra