SqlBulkCopy: Explicitly state column name that mismatches(#3170) #3183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
campersau
reviewed
Feb 27, 2025
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopyColumnMapping.cs
Outdated
Show resolved
Hide resolved
|
|
||
| if(!columnMapping._matchedOrRejected) | ||
| { | ||
| throw (SQL.BulkLoadNonMatchingColumnName(columnMapping.SourceColumn)); |
There was a problem hiding this comment.
Does changing from SQL.BulkLoadNonMatchingColumnMapping() to SQL.BulkLoadNonMatchingColumnName() affect our API promises? They both end up throwing InvalidOperationException, so probably not. Callers shouldn't be depending on the message of the exception, but you never know!
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/MissingTargetColumn.cs
Show resolved
Hide resolved
paulmedynski
requested changes
Feb 27, 2025
paulmedynski
approved these changes
Mar 5, 2025
apoorvdeshmukh
approved these changes
Mar 5, 2025
|
@JNjenga - Thanks for the changes! |
This was referenced Jul 25, 2025
Open
This was referenced Aug 15, 2025
Open
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing
SQL.BulkLoadNonMatchingColumnMappingexception when column mappings mismatch does not provide enough information about where the error occurred. ThrowingSQL.BulkLoadNonMatchingColumnNameexception is more appropriate.Fixes (#3170)