WIP | Create Extensions package #3471
Conversation
| @@ -327,9 +349,8 @@ stages: | |||
| # ways to detect if they were present) won't run consistently across forks and non-forks. | |||
| ${{ if eq(variables['system.pullRequest.isFork'], 'False') }}: | |||
| AADPasswordConnectionString: $(AAD_PASSWORD_CONN_STR) | |||
| AADServicePrincipalId: $(AADServicePrincipalId) | |||
| ${{ if eq(variables['system.pullRequest.isFork'], 'False') }}: | |||
There was a problem hiding this comment.
My YAML linter was complaining about duplicate keys because these ${{if ...} lines are the same. Similar changes below for the enclave test configurations.
| used by the build tooling and may be unintentionally included in other | ||
| (non-MDS) projects. | ||
| --> | ||
| <NugetPackageVersion Condition="'$(NugetPackageVersion)' == ''">$(MdsVersionDefault).$(BuildNumber)-dev</NugetPackageVersion> |
There was a problem hiding this comment.
Minor tweak here - I added $(BuildNumber) - not sure if that's helpful, but it matches how the Extensions package does things.
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
paulmedynski
force-pushed
the
dev/paul/azure-split/extensions
branch
from
ba927b7 to
6a52ede
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3471 +/- ##
===========================================
+ Coverage 59.44% 90.82% +31.37%
===========================================
Files 268 6 -262
Lines 62160 316 -61844
===========================================
- Hits 36950 287 -36663
+ Misses 25210 29 -25181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
force-pushed
the
dev/paul/azure-split/extensions
branch
3 times, most recently
from
0364a29 to
9192601
Compare
paulmedynski
force-pushed
the
dev/paul/azure-split/extensions
branch
from
9192601 to
54d6245
Compare
There was a problem hiding this comment.
I decided to give .slnx format a try, and so far the tooling supports it.
|
Thanks for this - I've got no comments or feedback on the design, other than the cosmetic note that Microsoft.Extensions.Logging and Microsoft.Extensions.DependencyInjection rely upon packages with the ".Abstractions" suffix, rather than ".Extensions". Interestingly, there's also a sizable improvement in AOT application size as a result of removing the Azure components from the main package. In my sample application, doing so cut the size of a 13.2MB application by about a third. |
I like the
Is there any benefit in
Excellent - more tangible benefits! |
|
Maybe this issue would cause changes you would want to incorporate here? |
- Added empty Extensions package with some sample class and docs to demonstrate packaging. - Created CI stage to build, test, pack, and publish the Extensions NuGet package. - Updated downstream CI stages/jobs to use the Extensions package. - Updated build.proj Clean target to not delete packages/ dir. - Updated BUILDGUIDE with instructions for the Extensions package. - Cleaned up stale BUIDGUIDE sections. - Added temporary GitHub Discussion content so the team can review before posting it as a real Discussion. - Disable .pdb file inclusion in the application package.
paulmedynski
force-pushed
the
dev/paul/azure-split/extensions
branch
from
c854293 to
e912975
Compare
|
Closing in favour of #3567 . |
Description
Work in Progress - This PR is a draft while I get the CI machinery working.
As part of the Azure split work, a new Extensions package is being created that contains types shared between MDS and its future extensions (Azure will be the first). This PR creates that package (with no meaningful content) to setup the MDS dependency, and get testing and CI setup accordingly.
I'm also experimenting with simplified .slnx files and some project directory structure changes.
Issues
The first step towards #1108.
Testing