Skip to content

Fix project dependencies #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

Fix project dependencies #3560

merged 1 commit into from
Aug 13, 2025

Conversation

cheenamalhotra
Copy link
Member

Also fixes building solution in VS Code.

@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 17:44
@cheenamalhotra cheenamalhotra requested a review from a team as a code owner August 12, 2025 17:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes project dependencies by adding missing Azure.Core package references and consolidating dependency management. The changes ensure that Azure.Core is properly referenced across all target frameworks and project types, while also standardizing how certain dependencies are managed.

  • Adds Azure.Core dependency to all target frameworks in the NuGet package specification
  • Consolidates package references by moving common dependencies to the main project file
  • Adds Azure.Core package reference to all .NET Framework and .NET Core project files

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/specs/Microsoft.Data.SqlClient.nuspec Adds Azure.Core dependency to all target framework groups
src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj Consolidates package references and adds missing dependencies
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj Adds Azure.Core package reference for .NET Framework implementation
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj Adds Azure.Core package reference for .NET Framework reference assembly
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj Adds Azure.Core package reference for .NET Core implementation
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj Adds Azure.Core package reference for .NET Core reference assembly

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@cheenamalhotra cheenamalhotra added this to the 7.0-preview1 milestone Aug 12, 2025
@cheenamalhotra cheenamalhotra merged commit c0b0da5 into main Aug 13, 2025
223 of 249 checks passed
@cheenamalhotra cheenamalhotra deleted the dev/cheena/fix-project-deps branch August 13, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants