[Xamarin.Android.Build.Tasks] Dont use a temp location for AssemblyAttribute.cs #3354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Jul 16, 2019
…tribute.cs Context dotnet#1240 As part of the build process MSBuild generates an `AssemblyAttribute.cs` class, such as MonoAndroid,Version=v9.0.AssemblyAttributes.cs This is the file which adds the `TargetFrameworkAttribute` to the assembly. While investigating dotnet#1240 I noticed that `_GenerateJavaStubs` was ALWAYS running, even on incremental builds with no changes. Digging into the build logs, `CoreCompile` was running because it thought one of the binding project assemblies was newer..? Digging in a bit more and I found this in the Binding Library build output on the `CoreCompile` target. Input file "/var/folders/n_/vt_nzq1n04schx5yy2jgcgcw0000gn/T/MonoAndroid,Version=v9.0.AssemblyAttributes.cs" is newer than output file "obj/Release/Xamarin.Android.McwGen-Tests.pdb". It turns out our binding targets were missing a few lines which exist in the common targets. These line set the `TargetFrameworkMonikerAssemblyAttributesPath` msbuild property to be located in the `$(IntermediateOutputPath)`. If this value is NOT set it turns out MSBuild defaults to dropping this file into a temp directory. That means it can be cleaned up at any point which will trigger a full build. :face_palm. So lets use the same few lines from the common targets to make sure we generate this file in our `$(IntermediateOutputPath)`. This stopped `_GenerateJavaStubs` from running when there were no changes (as expected). I updated one of our binding tests to check to make sure certain targets DO NOT run on an incremental build. Similar to what we do with our application targets.
dellis1972
force-pushed
the
bindingtargets
branch
from
874e3bb to
de288ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #1240
As part of the build process MSBuild generates an
AssemblyAttribute.csclass, such asThis is the file which adds the
TargetFrameworkAttributeto the assembly. While investigating #1240 I noticed that
_GenerateJavaStubswas ALWAYS running, even onincremental builds with no changes. Digging into the build
logs,
CoreCompilewas running because it thought oneof the binding project assemblies was newer..?
Digging in a bit more and I found this in the Binding Library
build output on the
CoreCompiletarget.It turns out our binding targets were missing a few lines which
exist in the common targets. These line set the
TargetFrameworkMonikerAssemblyAttributesPathmsbuild propertyto be located in the
$(IntermediateOutputPath). If thisvalue is NOT set it turns out MSBuild defaults to dropping
this file into a temp directory. That means it can be cleaned
up at any point which will trigger a full build. :face_palm.
So lets use the same few lines from the common targets to
make sure we generate this file in our
$(IntermediateOutputPath).This stopped
_GenerateJavaStubsfrom running when there wereno changes (as expected).
I updated one of our binding tests to check to make sure certain
targets DO NOT run on an incremental build. Similar to what we
do with our application targets.