[Mono.Android] Enable constants on interfaces. #4372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
|
API diff is yuge. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonpryor
pushed a commit
that referenced
this pull request
Mar 15, 2020
Context: dotnet/java-interop#509 Context: https://gist.github.com/jpobst/31c692a67a7f0389895b59cca92480ff Beginning with C#8, interfaces may now contain constants. This allows us to better match the `android.jar` we are binding. To enable `generator` to emit interfaces which contain constants, update `$(_LangFeatures)` to contain `--lang-features=interface-constants` when `$(AndroidApiLeve)` >= 30, e.g. for API-R preview bindings. This does not remove any previously created constants. We will need to `[Obsolete]` them in a future PR.
|
Draft release note This sounds like it might be interesting to mention under the Preview bindings for Android 11 Developer Preview section that will be in the release notes. Here's what I'm thinking of adding for this PR: To suggest something different or to recommend excluding it from the release notes, feel free to reply in this PR or add a |
|
@brendanzagaeski Good call, I modified your comment to add some more details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop#509
Beginning with C#8, interfaces may now contain constants. This allows us to better match the
android.jarwe are binding.This PR:
generatorflag:--lang-features=interface-constants, which will generates constants on interfaces using C#8.[Obsolete]them in a future PR.API diff between
masterAPI-30and this PR: https://gist.github.com/jpobst/31c692a67a7f0389895b59cca92480ff