Merging internal commits for release/8.0

[vseanreesermsft]

No description provided.

[Copilot]

Pull Request Overview

This PR merges internal commits to support the release of version 8.0 by refining the sign-in behavior and adding tests for extra scenarios.

• Updated the CanResignIn method signature and test setups by removing obsolete pragma warnings and clarifying the authentication scheme.
• Added two new tests to validate that RefreshSignInAsync correctly logs an error and performs no sign in when the authentication state is invalid or associated with a different user.
• Refactored RefreshSignInAsync in SignInManager to check for authentication success and user consistency before updating claims.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File	Description
src/Identity/test/Identity.Test/SignInManagerTest.cs	Updated test method signature and added tests ensuring proper behavior/logging in RefreshSignInAsync scenarios.
src/Identity/Core/src/SignInManager.cs	Reordered checks in RefreshSignInAsync to improve authentication validation logic.

Comments suppressed due to low confidence (3)

src/Identity/test/Identity.Test/SignInManagerTest.cs:602

• [nitpick] Consider defining a constant for the 'authscheme' string to minimize repetition and avoid magic strings in your test setups.

var id = new ClaimsIdentity("authscheme");

src/Identity/test/Identity.Test/SignInManagerTest.cs:655

• [nitpick] Consider extracting the error message into a constant and referencing it in both the SignInManager implementation and tests to reduce brittleness when updating the message.

Assert.Contains("RefreshSignInAsync prevented because the user is not currently authenticated. Use SignInAsync instead for initial sign in.", logger.LogMessages);

src/Identity/Core/src/SignInManager.cs:180

• [nitpick] Since the preceding check ensures auth.Succeeded and a valid principal, the null propagation operators here are redundant and can be removed for clarity.

var authenticationMethod = auth?.Principal?.FindFirst(ClaimTypes.AuthenticationMethod);