Connect Inputs and Outputs Properly and Export CopyColumnTransform to (unofficial) ONNX operator #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add exporter for CopyColumnTransform 2. Remove duplicate definitions in ONNX graph
wschin
changed the title
|
This PR does not reference an issue. Can you please file one and reference it in the PR description? #Resolved |
|
Note that the newly generated test models generate the same values as the existing ones. Experiments were run with the latest runtime. #Resolved |
codemzs
reviewed
Oct 2, 2018
| /// </summary> | ||
| /// <param name="variableName">examined string</param> | ||
| /// <returns>True if the input argument has been used to denote an ONNX variable. Otherwise, False.</returns> | ||
| public abstract bool IsDefined(string variableName); |
There was a problem hiding this comment.
IsDefined [](start = 29, length = 9)
Can we please rename this to be more specific like "IsVariableDefined"? #Resolved
There was a problem hiding this comment.
codemzs
reviewed
Oct 2, 2018
vaeksare
approved these changes
Oct 9, 2018
|
|
||
| public void SaveAsOnnx(OnnxContext ctx) | ||
| { | ||
| var infos = GetOutputColumns(); |
There was a problem hiding this comment.
You are not using this infos anywhere. I am guessing it was originally meant to be used in the foreach but you decided to use _columns instead?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #955 , #968.
typefield for encoding the transform's C# name.