Skip to content

Don't use colon in dotnet.config #48071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 1, 2025

Docs PR: dotnet/docs#45589

Fixes #48009

@Copilot Copilot AI review requested due to automatic review settings April 1, 2025 14:10
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Apr 1, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates configuration keys in TestCommandParser.cs to remove colon usage, aligning with the documentation update.

  • Updated the configuration section key from "dotnet.test" to "dotnet.test.runner".
  • Modified the property key lookup from "runner:name" to "name".
Files not reviewed (16)
  • test/TestAssets/TestProjects/HybridTestRunnerTestProjects/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/MSTestMetaPackageProjectWithMultipleTFMsSolution/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/MultiTestProjectSolutionWithDifferentFailures/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/MultiTestProjectSolutionWithDiscoveredTests/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/MultiTestProjectSolutionWithTests/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/MultipleTestProjectSolution/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/MultipleTestProjectsWithoutSolution/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/ProjectSolutionForMultipleTFMs/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/TestProjectSolution/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/TestProjectSolutionWithCodeCoverage/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/TestProjectSolutionWithTestsAndArtifacts/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/TestProjectWithClassLibrary/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/TestProjectWithConditionOnGlobalProperty/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/TestProjectWithDiscoveredTests/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/TestProjectWithMultipleTFMsSolution/dotnet.config: Language not supported
  • test/TestAssets/TestProjects/TestProjectWithTests/dotnet.config: Language not supported
Comments suppressed due to low confidence (2)

src/Cli/dotnet/Commands/Test/TestCommandParser.cs:177

  • [nitpick] The configuration section key was updated to 'dotnet.test.runner' to eliminate colon usage. Please verify that all parts of the codebase use the updated section name, consistent with the new configuration format.
var testSection = config.GetSection("dotnet.test.runner");

src/Cli/dotnet/Commands/Test/TestCommandParser.cs:184

  • [nitpick] The key used to retrieve the runner name was changed from 'runner:name' to 'name'. Confirm that this update matches the configuration file's structure and intended design.
string runnerNameSection = testSection["name"];

@edvilme
Copy link
Contributor

edvilme commented Apr 1, 2025

Is this related to #48009?

@Youssef1313
Copy link
Member Author

Is this related to #48009?

Yes. I edited the description to link it. Thanks!

@Youssef1313 Youssef1313 merged commit 117f981 into dotnet:main Apr 1, 2025
41 checks passed
@Youssef1313 Youssef1313 deleted the dotnet-config branch April 1, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current dotnet.config implementation violates TOML spec
3 participants