Limit the expected search location for the dotnet muxer from the sdk resolver result #49824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the SDK resolver to use a more restrictive approach for locating the dotnet muxer binary. Instead of probing up the file system hierarchy, it now assumes the standard SDK layout where the muxer is exactly two directories above the SDK directory.
- Replaces upward directory traversal with direct path calculation based on expected SDK layout
- Renames method and variables to better reflect the muxer-specific functionality
- Improves documentation to explain the expected relationship between SDK and muxer locations
src/Resolvers/Microsoft.DotNet.MSBuildSdkResolver/MSBuildSdkResolver.cs
Outdated
Show resolved
Hide resolved
rainersigwald
approved these changes
Jul 16, 2025
src/Resolvers/Microsoft.DotNet.MSBuildSdkResolver/MSBuildSdkResolver.cs
Outdated
Show resolved
Hide resolved
…solver.cs Co-authored-by: Rainer Sigwald <[email protected]>
baronfel
force-pushed
the
limit-dotnet-muxer-search-scope
branch
from
4ec8454 to
6326120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We limit the probing to the expected layouts instead of allowing unrestricted probing up the file system.
Also part of #49363