Simplify CriticalCopyPixels in BitmapSource by removing duplicate type checks

[h3xds1nz]

Description

Removes redundant type checks second-time around when copying pixels in CriticalCopyPixels. There's a small performance improvement, however, the main goal here is decreasing code size, and also code simplification that has been made possible with the introduction of GetArrayDataReference few releases ago.

Since Unsafe.AddByteOffset won't do an index-out-of-bounds check for us, we do it ourselves to keep the same behaviour as previously, throwing IndexOutOfRangeException on when offset exceeds the array length.

Customer Impact

Smaller code-size of PresentationCore.

Regression

No.

Testing

Local build.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

[h3xds1nz]

Resolved merge conflicts 06

[siagupta0202]

@h3xds1nz this PR is good to be merged. Can you please resolve the merge conflicts?

[h3xds1nz]

@siagupta0202 Done, sorry for the delay.

[ThomasGoulet73]

@h3xds1nz: Just a ping to let you know that the test failures in this PR were fixed in main, pulling main should fix the failures.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 10.95136%. Comparing base (d94671d) to head (2bd0281).
Report is 2 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main       #9395         +/-   ##
===================================================
- Coverage   10.99508%   10.95136%   -0.04373%     
===================================================
  Files           3215        3215                 
  Lines         648472      648440         -32     
  Branches       71534       71528          -6     
===================================================
- Hits           71300       71013        -287     
- Misses        576170      576436        +266     
+ Partials        1002         991         -11     

Flag	Coverage Δ
Debug	10.95136% <0.00000%> (-0.04373%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[siagupta0202]

@h3xds1nz this PR is good to be merged. Can you please resolve the merge conflicts?

No problem, and thank you so much for your contributions!

[h3xds1nz]

@siagupta0202 Thank you, happy to contribute :)