-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add test coverage for public API surface of MouseActionConverter #9891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good point, this looks like an issue in the class implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of the changes look good to me.
...pf/tests/UnitTests/PresentationCore.Tests/System/Windows/Input/MouseActionConverter.Tests.cs
Outdated
Show resolved
Hide resolved
...pf/tests/UnitTests/PresentationCore.Tests/System/Windows/Input/MouseActionConverter.Tests.cs
Outdated
Show resolved
Hide resolved
c3d0283
to
085c76e
Compare
@dipeshmsft Added a bit more cases as well and converted to file-scoped as with all my newer tests (will do that bit for TextDecorations as well). It's rebased btw so I had to force push. |
Description
Adds test coverage for
MouseActionConverter
. I've also fixed an unintentional behavioral change I've introduced with #9676, which would mean it wouldn't throwInvalidEnumArgumentException
due to passing wrong value type to the exception.CanConvertTo
throwsInvalidCastException
due to an unboxing cast when you pass anint
ConvertTo
when you pass anint
within rangeCustomer Impact
Improved test coverage on public surface.
Regression
Fixing my own oversight at the same time.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow