Skip to content

Replace enums with strings in the DB, JobSubmission.termination_reason, and Run.termination_reason #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 11, 2025
Merged

Replace enums with strings in the DB, JobSubmission.termination_reason, and Run.termination_reason #2949

merged 5 commits into from
Aug 11, 2025

Conversation

r4victor
Copy link
Collaborator

@r4victor r4victor commented Aug 6, 2025

Closes #2724
Closes #2756

This PR:

  • Stores all enums as strings in the DB so that DB migrations are not needed when adding new members to enums.
  • Makes JobSubmission.termination_reason and Run.termination_reason strings so that adding new termination reasons is possible without breaking old clients.

@r4victor r4victor changed the title Issue 2724 enums as strings Replace enums with strings in the DB, JobSubmission.termination_reason, and Run.termination_reason Aug 6, 2025
@r4victor r4victor merged commit 0fea032 into master Aug 11, 2025
25 checks passed
@r4victor r4victor deleted the issue_2724_enums_as_strings branch August 11, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Internal] Start using important job termination reasons Allow introducing job and run termination reasons without breaking compatibility
1 participant
@r4victor