Fix cfg checks when compiled with --target
#207
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since the docs.rs update[1] the docs here don't compile.[2]
it seems like this is happening because now the build command also pass
--target x86_64-unknown-linux-gnu
which makes the conditional compilations in the build script not work correctly.From the cargo reference[3] it seems like the solution is to use the environment variable
CARGO_CFG_<cfg>
instead of thecfg
macro.This PR does it and adds to travis a test that mimics the docs.rs configuration [4]
If this somehow a bug and not a feature in cargo or something I'm missing would love to know :)
[1] https://blog.rust-lang.org/2019/09/18/upcoming-docsrs-changes.html
[2] https://docs.rs/crate/proc-macro2/1.0.6/builds
[3] https://doc.rust-lang.org/cargo/reference/environment-variables.html
[4] https://docs.rs/about