Remove OpenTelemetry class #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since deserialization happens in the main client, this is the place where the OpenTelemetry class and context manager should live.
pquentin
force-pushed
the
otel-elasticsearch-py
branch
from
41c85a8 to
075c369
Compare
| @@ -174,7 +174,7 @@ def __init__( | |||
| # sniffing. Uses '_sniffing_task' instead. | |||
| self._sniffing_lock = None # type: ignore[assignment] | |||
|
|
|||
| async def perform_request( # type: ignore[override] | |||
There was a problem hiding this comment.
I assume we do not care that the public interface of this method changes? This is called only by the client library package (which we are also updating in parallel)? Any other possible callers that may break with this change?
There was a problem hiding this comment.
In general we do care about the public interface, which is used by projects like https://github.com/elastic/enterprise-search-python, https://github.com/elastic/elasticsearch-serverless-python and https://github.com/ywangd/peek/. But:
- We don't care about removing
endpoint_idandpath_partsfrom the signature because this change was never released. - We don't care about adding
otel_spanbecause it is a new keyword argument with a default value, and thus not breaking.
miguelgrinberg
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since deserialization happens in the main client, this is the place where the OpenTelemetry class and context manager should live.