-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Drop support for Python 3.8 #3001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e1faa21
to
b1987fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git grep 3\\.8
gives other things to change:
docs/reference/getting-started.md:* [Python](https://www.python.org/) 3.8 or newer
examples/fastapi-apm/dockerfiles/Dockerfile.app:FROM python:3.8
examples/fastapi-apm/dockerfiles/Dockerfile.ping:FROM python:3.8
utils/dsl-generator.py: # When dropping Python 3.8, use `removesuffix("Function")` instead
Additionally, running pyupgrade --py38-plus **/*.py
produces a few more interesting changes.
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-3001-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 14bfbf26a38112df6ba7f058f316a8d123219b39
# Push it to GitHub
git push --set-upstream origin backport-3001-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1 Then, create a pull request where the |
No description provided.