Skip to content

Address integration test failures in Python 3.8 #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

miguelgrinberg
Copy link
Contributor

@miguelgrinberg miguelgrinberg commented Jul 31, 2025

Three changes that address some of the recent failures we've been seeing in integration test runs.

  1. The wipe_indices() function that we use to reset the Elasticsearch database between tests had a small parsing bug that caused it to fail, and leave some indices in the database. This in turn could cause the next test to fail, either due to being unable to create an index, or more likely to fail in obscure ways when the test results were different because the index existed from before with data from another test.
  2. While debugging the first issue, I noticed that some test runs fail to download the YAML tests, so these were being skipped. The error was "too many redirect" from urllib3. I've added more redirects to make sure that these tests are not skipped.
  3. There was one of the YAML tests that failed (main and 9.1 branches only). I have added this test to the list of known failures.

@miguelgrinberg miguelgrinberg force-pushed the fix-3.8-builds branch 3 times, most recently from f8a67e0 to a511987 Compare August 1, 2025 10:46
@miguelgrinberg miguelgrinberg changed the title troubleshooting build Address integration test failures in Python 3.8 Aug 1, 2025
@miguelgrinberg miguelgrinberg changed the base branch from 9.0 to main August 1, 2025 11:43
@miguelgrinberg miguelgrinberg changed the base branch from main to 9.0 August 1, 2025 11:44
@miguelgrinberg miguelgrinberg changed the base branch from 9.0 to main August 1, 2025 11:47
@miguelgrinberg miguelgrinberg marked this pull request as ready for review August 1, 2025 15:28
@miguelgrinberg miguelgrinberg merged commit 67c444c into elastic:main Aug 1, 2025
20 checks passed
@miguelgrinberg miguelgrinberg deleted the fix-3.8-builds branch August 1, 2025 15:30
github-actions bot pushed a commit that referenced this pull request Aug 1, 2025
github-actions bot pushed a commit that referenced this pull request Aug 1, 2025
github-actions bot pushed a commit that referenced this pull request Aug 1, 2025
github-actions bot pushed a commit that referenced this pull request Aug 1, 2025
github-actions bot pushed a commit that referenced this pull request Aug 1, 2025
miguelgrinberg added a commit that referenced this pull request Aug 1, 2025
(cherry picked from commit 67c444c)

Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg added a commit that referenced this pull request Aug 1, 2025
(cherry picked from commit 67c444c)

Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg added a commit that referenced this pull request Aug 1, 2025
(cherry picked from commit 67c444c)

Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg added a commit that referenced this pull request Aug 1, 2025
(cherry picked from commit 67c444c)

Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg added a commit that referenced this pull request Aug 1, 2025
* Address integration test failures in Python 3.8 (#3018)

(cherry picked from commit 67c444c)

* add one more test to the failing list

---------

Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant