-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Address integration test failures in Python 3.8 #3018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8a67e0
to
a511987
Compare
c505a47
to
b236c34
Compare
b236c34
to
14de7a1
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
(cherry picked from commit 67c444c)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
(cherry picked from commit 67c444c)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
(cherry picked from commit 67c444c)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
(cherry picked from commit 67c444c)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
(cherry picked from commit 67c444c)
miguelgrinberg
added a commit
that referenced
this pull request
Aug 1, 2025
(cherry picked from commit 67c444c) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Aug 1, 2025
(cherry picked from commit 67c444c) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Aug 1, 2025
(cherry picked from commit 67c444c) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Aug 1, 2025
(cherry picked from commit 67c444c) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Aug 1, 2025
* Address integration test failures in Python 3.8 (#3018) (cherry picked from commit 67c444c) * add one more test to the failing list --------- Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes that address some of the recent failures we've been seeing in integration test runs.
wipe_indices()
function that we use to reset the Elasticsearch database between tests had a small parsing bug that caused it to fail, and leave some indices in the database. This in turn could cause the next test to fail, either due to being unable to create an index, or more likely to fail in obscure ways when the test results were different because the index existed from before with data from another test.