Java issues batch 5 #2552
Merged
Java issues batch 5 #2552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2024
* range for aggregations should just accept double (666) * added version to fieldType enum (673) * script field missing from keywordProperty (690) * default variant for normalizers (696) * remodeled dynamic template (648) (cherry picked from commit 982cc3c)
l-trotta
added a commit
that referenced
this pull request
May 28, 2024
* range for aggregations should just accept double (666) * added version to fieldType enum (673) * script field missing from keywordProperty (690) * default variant for normalizers (696) * remodeled dynamic template (648) (cherry picked from commit 982cc3c) Co-authored-by: Laura Trotta <[email protected]>
l-trotta
added a commit
that referenced
this pull request
May 28, 2024
This was referenced May 28, 2024
l-trotta
added a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes provided in this PR:
toandfrom. But in the spec we just use it in GeoDistanceAggregation and RangeAggregation, both accepting only doubles. Since the java client generalizesstring | doubleas just string, this results in the server throwing exceptions when called.version. docsscriptandonScriptErrorfields. server codetypefield).mappingandruntimecan be used alternatively (it's explained in the docs) so both fields are maps and only one must be set (therefore the container variant).