Skip to content

Update Inference specification for Azure AI Studio rerank task #4953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Evgenii-Kazannik
Copy link
Contributor

Update specification related to Add-Azure-AI-Foundry-Rerank-support

Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@l-trotta
Copy link
Contributor

is this just for 9.1? is there a server pr reference?

"type": "boolean"
},
"top_n": {
"description": "For a `rerank` task, the number of the top N documents that should be returned.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Can we instead use the description we use for some of our other services with the same value For a rerank task, the number of most relevant documents to return.\nIt defaults to the number of the documents.. I think it's potentially a bit more clear and provides a bit of extra information on what happens when the value is not set.

Same applies for the other descriptions for this value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better. Thanks. Updated with this description

"type": "boolean"
},
"top_n": {
"description": "For a `rerank` task, the number of most relevant documents to return.\\nIt defaults to the number of the documents.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, does this need to be \\n or should it just be \n?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Dan.
I removed a special character in order the json to be generated correctly

@Evgenii-Kazannik Evgenii-Kazannik added the skip-backport This pull request should not be backported label Jul 22, 2025
@Evgenii-Kazannik Evgenii-Kazannik merged commit 34b8463 into main Jul 22, 2025
9 of 10 checks passed
@Evgenii-Kazannik Evgenii-Kazannik deleted the Update-inference-specification-for-Azure-AI-Foundry-rerank-task branch July 22, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-backport This pull request should not be backported specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants