-
Notifications
You must be signed in to change notification settings - Fork 106
Update Inference specification for Azure AI Studio rerank task #4953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Inference specification for Azure AI Studio rerank task #4953
Conversation
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
is this just for 9.1? is there a server pr reference? |
"type": "boolean" | ||
}, | ||
"top_n": { | ||
"description": "For a `rerank` task, the number of the top N documents that should be returned.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Can we instead use the description we use for some of our other services with the same value For a
rerank task, the number of most relevant documents to return.\nIt defaults to the number of the documents.
. I think it's potentially a bit more clear and provides a bit of extra information on what happens when the value is not set.
Same applies for the other descriptions for this value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's better. Thanks. Updated with this description
…Foundry-rerank-task
"type": "boolean" | ||
}, | ||
"top_n": { | ||
"description": "For a `rerank` task, the number of most relevant documents to return.\\nIt defaults to the number of the documents.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, does this need to be \\n
or should it just be \n
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Dan.
I removed a special character in order the json to be generated correctly
…Foundry-rerank-task
Update specification related to Add-Azure-AI-Foundry-Rerank-support