Highlighting issues inside triple-quoted strings

[whatyouhide]

Example from the Plug docs:

I can reproduce it with just any triple-quoted string:

This also leads to an incorrect behaviour when " strings inside triple-quoted strings don't have both the surrounding quotes. As always, we're better off with an example:

IMO, stuff inside triple-quoted strings should be just highlighted as a string, whatever characters it contains. What do you think?

[tonini]

@whatyouhide Thanks for opening an issue for this one.

I think @mattdeboard has a much better knowledge about how elixir-mode handles heredoc representation. I know he has a lot to do, but maybe he could have a quick look into it. <3 :-)

[mattdeboard]

Triple-quoted strings are extremely difficult. I have tried many times to get this right. :(

The only thing I can suggest is to copy and paste python-mode's impl.

[whatyouhide]

I'd like to help a lot, but I really have not enough Emacs/elisp knowledge to to basically anything.

It seems odd that triple-quoted-strings are so difficult to highlight correctly. In vim (and vim-elixir), it's really simple to tell the editor to just highlight anything inside """ without breaking out of """s (giving it precedence over single-quoted strings and so on).

[andreas-roehler]

On 24.01.2015 20:06, Andrea Leopardi wrote:

[ ... ]

While maintaining python-mode.el, whill have a look at it.

Cheers,

Andreas

[tonini]

Great! Thanks a lot :-)

Andreas Röhler notifications@github.com schrieb am Di., 3. Feb. 2015
13:36:

On 24.01.2015 20:06, Andrea Leopardi wrote:

[ ... ]

While maintaining python-mode.el, whill have a look at it.

Cheers,

Andreas

—
Reply to this email directly or view it on GitHub
#167 (comment)
.

[andreas-roehler]

On 25.01.2015 19:08, Matt DeBoard wrote:

Triple-quoted strings are extremely difficult. I have tried many times to get this right. :(

The only thing I can suggest is to copy and paste python-mode's impl.

---

Reply to this email directly or view it on GitHub:
#167 (comment)

Hi Matt,

having a look into your related branch, must have been pretty close to solution.
Sometimes its a kind of woodoo :)

Andreas,
your new contributor/collaborator

[mattdeboard]

The issue here is that triple-quoted strings (TQS) only get highlighted "correctly" by accident. A single TQS is, to the highlighting algorithm, 3 pairs of quotes. So the opening triple-quote is actually 1 full pair of quotes, and one half-pair of quotes, which is why the behavior described by @whatyouhide is happening. The highlighter sees the " before application/json as the closing quote to the last " in the opening triple-quote.

[andreas-roehler]

Seems that bug is fixed in trunk meanwhile, close?

[andreas-roehler]

Hmm, no, still there.

[mattdeboard]

Fixed by #203

[whatyouhide]

❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ !!!