Indentation issue with function defined after requires

[Scramblejams]

Here's a strange one. I'll be pleasantly surprised if you can reproduce with 24.4.

defmodule RSS do
    require Enum
    require HTTPotion
    require Record  

                    def zip(list1, list2) when length(list1) == length(list2) do

Emacs 24.3.1, elixir-mode 1.4.8.

[mattdeboard]

It's actually just after require Record :P

If you remove the final require, the indentation is fine.

[mattdeboard]

I mention this not as a workaround of course, but as a note to myself or future maintainers.

[mattdeboard]

The indentation I actually get is:

defmodule RSS do
  require Enum
  require HTTPotion
  require Record  

          def zip(list1, list2) when length(list1) == length(list2) do

[mattdeboard]

This reminds me that I do not have any place in the grammar for guard clauses.

[mattdeboard]

This is really odd.

If I just paste the first four lines:

defmodule RSS do
  require Enum
  require HTTPotion
  require Record

then, after Record, hit <ENTER>, THEN paste lines 5-6, indentation seems to work ok. This makes testing really hard. Hm.

[mattdeboard]

I wrote the following test which was supposed to fail. Inexplicably, it passed. :)

(elixir-def-indentation-test indent-after-require-Record
    (:expected-result :failed)
  "
defmodule RSS do
require Record

def zip(list1, list2) when length(list1) == length(list2) do
x = 1
end
end"
  "
defmodule RSS do
  require Record

  def zip(list1, list2) when length(list1) == length(list2) do
    x = 1
  end
end")

[mattdeboard]

Oh, I think I see.

@Scramblejams Not that this is good or anything, but it looks like the extra whitespace after Record is tricking the indentation engine somehow. If you trim that, it works as expected. What a strange indentation error. Thanks for bringing it to my attention.

[Scramblejams]

Nice work! Didn't even notice the extra whitespace, sorry, otherwise I'd have pointed it out. Thanks for investigating thoroughly.