IMenu: Add 'Tests' as menu entries #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing 'default-tab-width' makes no sense. Only changing 'tab-width' is enough to changing tab size of buffer. And 'default-tab-width' causes a byte-compile warning because it is obsolete variable.
|
hmm - I did a 'git rebase upstream/master', but is the result cleaner? I can delete my repo, clone again and apply this small patch and create another PR if not. Or could you just cherry-pick f5bcd8e ? |
|
If you already made the changes in a separat branch: First I would update your local master branch git fetch upstream
git merge upstream
git checkout <branch-with-changes>
git rebase master |
|
This was FUBAR, #40 is clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important commit is b027891, a very simple and small change to have ExUnit test cases appear in the IMenu.