Fix auto-closing quotes for heredocs #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add triple double quotes (`"""`) as an auto-closing pair in the Elixir language configuration to prevent extra quotes from being inserted when starting a heredoc string.
|
Can you make it work with sigils?
Ideally typing |
|
Sure thing, but the list of applicable sigils will have to be hard coded (I don’t think VS Code allows something like “a tilde followed by any letter and three double quotes”). I’m new to Elixir, so what sigils (besides |
|
@jarrodldavis emacs-elixir has a good list that was just updated for ~L: https://github.com/elixir-editors/emacs-elixir/pull/454/files |
- add auto-closing pairs for triple double quotes with sigils - since adding those auto closing pairs breaks single double quote pairs, add pairs for single double quotes with sigils as well - the sigil list is from elixir-editors/emacs-elixir#454
|
Sweet, it works perfectly. |
axelson
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add triple double quotes (
""") as an auto-closing pair in the Elixir language configuration to prevent extra quotes from being inserted when starting a heredoc string.