add support for flashing direct-boot images to esp32c3 #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Code looks good to me. Unfortunately I have a rev 2 version of the ESP32-C3 so I am unable to test this. I assume you've verified it, but maybe @MabezDev or @mchodzikiewicz can confirm.
MabezDev
approved these changes
Oct 14, 2021
|
@jessebraham I didn't see the revision limitation for direct boot till now. I've added an extra check to get a proper error message for this case. Can you check that this works properly with your c3 |
|
I received an error message as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
Tested with https://github.com/MabezDev/esp32c3-experiments
Todo:
--formatoptionsCargo.toml