fix(spi): Fix bus clock for ESP32-P4 + remove S2 leftover #11547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-R-O-C-H-Y
added
Area: Peripherals API
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 13m 6s ⏱️ Results for commit 13333d2. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates SPI initialization for the ESP32-P4 target by adding proper low-level SPI clock handling and removing outdated S2 support.
- Adds
hal/spi_ll.hinclude for ESP32-P4 - Removes legacy DPORT-based clock/reset for unsupported configurations
- Implements atomic clock enable/reset for FSPI and HSPI on ESP32-P4
Comments suppressed due to low confidence (2)
cores/esp32/esp32-hal-spi.c:663
- [nitpick] Consider adding a brief comment explaining the purpose of this ESP32-P4–specific atomic clock/reset block to clarify why legacy DPORT calls were removed.
#elif CONFIG_IDF_TARGET_ESP32P4
cores/esp32/esp32-hal-spi.c:664
- This new ESP32-P4 path introduces logic for both FSPI and HSPI; consider adding unit or integration tests covering both branches to prevent regressions on P4.
if (spi_num == FSPI) {
me-no-dev
approved these changes
Jul 3, 2025
me-no-dev
added
Status: Pending Merge
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
github-project-automation
bot
moved this from In Review
to Done
in Arduino ESP32 Core Project Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request updates the SPI handling for the ESP32P4 target in the
cores/esp32/esp32-hal-spi.cfile. It introduces new logic for enabling and resetting SPI bus clocks specific to ESP32P4 and removes legacy handling for unsupported configurations.Tests scenarios
Tested using ESP32-P4 and SD card example. Tested both FSPI and HSPI.
Related links
Closes #11398