Skip to content

[Storage Analyser] Fix total storage pie chart #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 23, 2025

Conversation

RKBoss6
Copy link
Contributor

@RKBoss6 RKBoss6 commented Jul 22, 2025

I noticed the total storage pie chart was showing 100% free due to a bug, fixed now. I also added rounding for ease of viewing.

@RKBoss6 RKBoss6 marked this pull request as draft July 22, 2025 20:05
@bobrippling
Copy link
Collaborator

Code looks good - I appreciate this is still a draft, but will this continue to be deployed to your github pages? If so, pop a link in and we'll check it out :)

@RKBoss6
Copy link
Contributor Author

RKBoss6 commented Jul 22, 2025

@bobrippling It already is :) Check it out!

@RKBoss6
Copy link
Contributor Author

RKBoss6 commented Jul 22, 2025

Everything works now :)

@RKBoss6 RKBoss6 marked this pull request as ready for review July 22, 2025 20:59
@bobrippling
Copy link
Collaborator

Nice! LGTM

@bobrippling bobrippling merged commit 2cc5a9b into espruino:master Jul 23, 2025
1 check passed
@RKBoss6 RKBoss6 deleted the StoragwAnalyser branch July 23, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants