Make cycle_callback a functor (+ rename cycle_callback -> data_callback) #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @param buf Buffer to copy data to | ||
| * @param max Maximum number of bytes allowed to be copied | ||
| * @return number of bytes copied, or |
There was a problem hiding this comment.
This can be improved by mirroring MHD documentation
|
This is definitely interesting. |
|
Added to the repo: #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be a need to preserve some state across calls to the callback. With this change, it becomes possible to do this using a subclass of data_callback [1].
I'm not sure if it's the best way to do it. The same can be done with a C++11 capturing lambda (and supported with templates on
libhttpserverside).Also, making it an alternative to a simple function pointer instead of replacing it looks like a better idea, but I don't know which way to do it is the best.