Skip to content

Unpin xarray dependency #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 15, 2025
Merged

Unpin xarray dependency #451

merged 17 commits into from
Jul 15, 2025

Conversation

gmaze
Copy link
Member

@gmaze gmaze commented Mar 3, 2025

[last edit]

This PR make argopy usable with the lastest xarray versions

Argopy is pinned to xarray < 2024.3 for more than a year now.

But xarray folks fixed pydata/xarray#8909 in pydata/xarray#10376 for versions starting on 2025.7

argopy is thus compatible with xarray versions older than 2024.3 or younger than 2025.7.

Close #390
Should also probably close #404 and address #373

@gmaze gmaze changed the title Fix xarray upstream compatibility Investigate xarray upstream compatibility fix Mar 3, 2025
@gmaze
Copy link
Member Author

gmaze commented Mar 3, 2025

Seems like ongoing work at pydata/xarray#9273 may fix the issue

@gmaze
Copy link
Member Author

gmaze commented Mar 3, 2025

🎊 indeed the dedicate tests suite is OK when using the xarray from pydata/xarray#9273 !

https://github.com/euroargodev/argopy/actions/runs/13632453669

Copy link

github-actions bot commented Jun 3, 2025

This pull request was marked as staled automatically because it has not seen any activity in 90 days

@github-actions github-actions bot added the stale No activity over the last 90 days label Jun 3, 2025
@gmaze
Copy link
Member Author

gmaze commented Jul 11, 2025

@github-actions github-actions bot removed the stale No activity over the last 90 days label Jul 11, 2025
@gmaze gmaze changed the title Investigate xarray upstream compatibility fix Unpin xarray dependency Jul 11, 2025
@gmaze gmaze marked this pull request as ready for review July 12, 2025 06:40
@gmaze gmaze linked an issue Jul 12, 2025 that may be closed by this pull request
@gmaze gmaze self-assigned this Jul 12, 2025
@gmaze gmaze added bug Something isn't working dependencies Pull requests that update a dependency file python-environment About Python environment setup labels Jul 12, 2025
@gmaze gmaze moved this from Queued to In Progress in Argopy Management Dashboard Jul 12, 2025
gmaze added 4 commits July 14, 2025 10:08
fix bug where by python 3.12 was casting integer in the list to numpy float 64 instead of simple float
@gmaze
Copy link
Member Author

gmaze commented Jul 15, 2025

Windows tests fail because of this unrelated issue #496
So all CI tests are considered passed with this PR
merging

@gmaze gmaze merged commit b4cc3cf into master Jul 15, 2025
29 of 40 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Argopy Management Dashboard Jul 15, 2025
@gmaze gmaze deleted the fix-xarray-upstream-compatibility branch July 15, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file python-environment About Python environment setup
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

xarray error with numpy > 2.0 on import Allow xarray>2024.03 in environment ScipyArrayWrapper' object has no attribute 'oindex'
1 participant