Fixes for miner #599
Merged
Fixes for miner #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ortyomka <[email protected]>
Signed-off-by: ortyomka <[email protected]>
Alexey-N-Chernyshov
approved these changes
Feb 17, 2022
| recordPieceInfo(deal_context->deal, maybe_piece_location.value()), | ||
| "Record piece failed", | ||
| deal_context); | ||
| deal_context->maybe_piece_location = maybe_piece_location.value(); | ||
| // TODO(a.chernyshov): add piece retry |
There was a problem hiding this comment.
I suppose the comment is not relevant anymore.
There was a problem hiding this comment.
It could be relevant, if sealing cannot store it for now. But after sometime it could
Signed-off-by: ortyomka <[email protected]>
wer1st
approved these changes
Feb 17, 2022
turuslan
reviewed
Feb 17, 2022
turuslan
reviewed
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
==========================================
+ Coverage 46.00% 46.02% +0.02%
==========================================
Files 713 715 +2
Lines 32293 32328 +35
Branches 17876 17885 +9
==========================================
+ Hits 14855 14880 +25
- Misses 13095 13102 +7
- Partials 4343 4346 +3
Continue to review full report at Codecov.
|
turuslan
approved these changes
Feb 17, 2022
Signed-off-by: ortyomka <[email protected]>
Markuu-s
pushed a commit
that referenced
this pull request
Mar 10, 2022
* Miner Fixes Signed-off-by: ortyomka <[email protected]>
Markuu-s
pushed a commit
that referenced
this pull request
Mar 10, 2022
* Miner Fixes Signed-off-by: ortyomka <[email protected]>
Markuu-s
pushed a commit
that referenced
this pull request
Mar 10, 2022
* Miner Fixes Signed-off-by: ortyomka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]