-
Notifications
You must be signed in to change notification settings - Fork 342
added support for automl-models #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Just a few comments on readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of suggestions.
firebase_admin/ml.py
Outdated
model_source = None | ||
gcs_tflite_uri = data.pop('gcsTfliteUri', None) | ||
if gcs_tflite_uri: | ||
model_source = TFLiteGCSModelSource(gcs_tflite_uri=gcs_tflite_uri) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
firebase_admin/ml.py
Outdated
model_source = TFLiteGCSModelSource(gcs_tflite_uri=gcs_tflite_uri) | ||
auto_ml_model = data.pop('automlModel', None) | ||
if auto_ml_model: | ||
model_source = TFLiteAutoMlSource(auto_ml_model=auto_ml_model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
firebase_admin/ml.py
Outdated
|
||
def __eq__(self, other): | ||
if isinstance(other, self.__class__): | ||
return self._auto_ml_model == other._auto_ml_model # pylint: disable=protected-access | ||
return self._auto_ml_model == other.auto_ml_model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return self._auto_ml_model == other.auto_ml_model | |
return self.auto_ml_model == other.auto_ml_model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
added support for automl-models