Skip to content

Add an initial version of App Check integration test #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 14, 2022
Merged

Conversation

a-maurice
Copy link
Contributor

@a-maurice a-maurice commented Oct 4, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Add an initial version of an integration test for App Check. It currently doesn't test much beyond creation of the providers.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Building and running the Android and Desktop versions locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Oct 4, 2022
@a-maurice a-maurice marked this pull request as ready for review October 6, 2022 00:37
@a-maurice a-maurice requested a review from AlmostMatt October 6, 2022 00:37
@AlmostMatt
Copy link
Contributor

To clarify, once this is committed will app check integration test be run as part of automated GHA integration test workflows? Will it run for all platforms?

If yes, can you link to a passing GHA workflow run, and if no, can you mention this in the PR description

@AlmostMatt
Copy link
Contributor

This generally looks good, I just want to be sure that this won't break existing GHA workflows.

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Oct 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit 07c75bc
Last updated: Fri Oct 14 16:49 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [1/3 os: macos] [1/2 android_device: emulator_target]
dynamic_links [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
storage [TEST] [ERROR] [iOS] [macos] [All 2 ios_device]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 8, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 8, 2022
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
As discussed, runs of the integration test workflow specify which projects to test and the default is to not test app check. So this won't break existing integration test workflows.

Some of the tests currently failed because the stubs are not yet implemented (for example, create provider returns null), but this is ok since the existence of this test is helpful to assist in such implementation, and this test is not run automatically.

@a-maurice a-maurice removed the tests: failed This PR's integration tests failed. label Oct 14, 2022
@a-maurice
Copy link
Contributor Author

Note that the lint warning is because this adds encrypted files, which obviously aren't lint compatible.

@a-maurice a-maurice merged commit 07c75bc into main Oct 14, 2022
@a-maurice a-maurice deleted the am-app_check_test branch October 14, 2022 20:42
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Oct 14, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 14, 2022
@firebase firebase locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants