-
Notifications
You must be signed in to change notification settings - Fork 124
Add an initial version of App Check integration test #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To clarify, once this is committed will app check integration test be run as part of automated GHA integration test workflows? Will it run for all platforms? If yes, can you link to a passing GHA workflow run, and if no, can you mention this in the PR description |
This generally looks good, I just want to be sure that this won't break existing GHA workflows. |
❌ Integration test FAILEDRequested by @a-maurice on commit 07c75bc
Add flaky tests to go/fpl-cpp-flake-tracker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
As discussed, runs of the integration test workflow specify which projects to test and the default is to not test app check. So this won't break existing integration test workflows.
Some of the tests currently failed because the stubs are not yet implemented (for example, create provider returns null), but this is ok since the existence of this test is helpful to assist in such implementation, and this test is not run automatically.
Note that the lint warning is because this adds encrypted files, which obviously aren't lint compatible. |
Description
Add an initial version of an integration test for App Check. It currently doesn't test much beyond creation of the providers.
Testing
Building and running the Android and Desktop versions locally
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.